This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Skip TestServiceRemoveKeepsIngressNetwork #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: moby#39426 This is a common flaky test that I have seen on multiple PRs. It is not consistent and should be skipped until it is fixed to be robust. A simple fix for the swarm tests is not easy as they all poll and have 1 billion timeouts in all the tests so a skip is valid here. Signed-off-by: Michael Crosby <[email protected]> (cherry picked from commit b942185) Signed-off-by: Sebastiaan van Stijn <[email protected]>
tiborvass
approved these changes
Sep 9, 2019
Member
Author
|
bringing this one in |
This was referenced Sep 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of moby#39453
Ref: moby#39426
This is a common flaky test that I have seen on multiple PRs. It is not
consistent and should be skipped until it is fixed to be robust. A
simple fix for the swarm tests is not easy as they all poll and have 1
billion timeouts in all the tests so a skip is valid here.