[18.09 backport] Bump containerd v1.2.6, runc v1.0.0-rc8

[thaJeztah]

backport for the 18.09 branch of:

• Bump containerd v1.2.6, runc 029124da7af7360afa781a0234d1b083550f797c moby/moby#39016 Bump containerd v1.2.6, runc 029124da7af7360afa781a0234d1b083550f797c
  • the last commit (moby@c28171c) was omitted, as it didn't appear to have relevant changes
• Bump runc 1.0.0-rc8, opencontainers/selinux v1.2.2 moby/moby#39143 Bump runc 1.0.0-rc8, opencontainers/selinux v1.2.2
  • only the runc binary 1.0.0-rc8 bump

[thaJeztah]

ping @dmcgowan @tonistiigi PTAL

[cpuguy83]

This runc commit causes a regression on selinux systems. moby#39109

[thaJeztah]

This runc commit causes a regression on selinux systems. moby#39109

@seemethere FYI

[thaJeztah]

@seemethere; I meant: fyi about the regression in runc 😅

[seemethere]

Ha I realized right after I approved. 😂

[dmcgowan]

LGTM

[cpuguy83]

opencontainers/selinux#51 (comment)

Dan says it's an issue container-selinux and it should be fixed.

[thaJeztah]

@cpuguy83 LGTY?

[thaJeztah]

Added the runc binary bump from moby#39143

[cpuguy83]

@cpuguy83 LGTY?

I can't verify that container-selinux fixes this since it doesn't appear to be updated yet.

[cpuguy83]

Ok, seemns the updated contaner-selinux is out and does resolve my issue with the updated runc.

[thaJeztah]

let me rebase this one to trigger CI

[thaJeztah]

rebased; will open a follow-up for containerd v1.2.7 separately

[thaJeztah]

Seeing these a lot; oddly, here, it fails on Experimental, but succeeds on Janky https://jenkins.dockerproject.org/job/Docker-PRs-experimental/45700/console

Possibly a race condition?

20:16:51 FAIL: docker_cli_run_test.go:1792: DockerSuite.TestRunInteractiveWithRestartPolicy
20:16:51 
20:16:51 assertion failed: 
20:16:51 Command:  /usr/local/cli/docker run -i --name test-inter-restart --restart=always busybox sh
20:16:51 ExitCode: 0
20:16:51 Error:    <nil>
20:16:51 Stdout:   
20:16:51 Stderr:   
20:16:51 
20:16:51 Failures:
20:16:51 ExitCode was 0 expected 11

20:21:07 FAIL: docker_cli_start_test.go:190: DockerSuite.TestStartReturnCorrectExitCode
20:21:07 
20:21:07 assertion failed: expected an error, got nil

Difference in environment:

Experimental:

Building remotely on ubuntu-1604-aufs (i-003abbf80f693c1e3) (docker-edge ubuntu aufs docker-stable docker ubuntu-1604-aufs-edge x86_64 ec2 linux ubuntu-1604-aufs ubuntu-1604 amd64 ubuntu-1604-aufs-stable) in workspace /home/ubuntu/workspace/Docker-PRs-experimental

Janky:

Building remotely on ubuntu-1604-overlay2 (i-0d7dabfc735eb19f6) (x86_64 ubuntu overlay2 linux ubuntu-1604 ubuntu-1604-overlay2 ubuntu-1604-overlay2-stable amd64) in workspace /home/ubuntu/workspace/Docker-PRs