Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

@andrewhsu
Copy link
Contributor

@andrewhsu andrewhsu commented Oct 30, 2017

Even though the PRs to the upstream moby/moby may pass, these tests fail consistently when integrated with the docker-ce repo which uses a newer version of docker/cli.

3 separate commits to disable the tests because they either need to be removed upstream or need adjustment.

Commit 38805b0 can be taken care of when docker/cli#654 is merged.

@andrewhsu andrewhsu added this to the 17.11.0 milestone Oct 30, 2017
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This integration-cli test is only testing CLI behaviour so should not be
in the engine side of tests.

Signed-off-by: Andrew Hsu <[email protected]>
Skipping integration-cli test because it should be moved to an API test.

Signed-off-by: Andrew Hsu <[email protected]>
…ipleTags

This integration-cli test needs to be fixed for change in `rmi -f`
behaviour.

Signed-off-by: Andrew Hsu <[email protected]>
@andrewhsu
Copy link
Contributor Author

Tests are green for the DockerSuite build: https://jenkins.dockerproject.org/job/docker-ce-pr/319/execution/node/416/log/ which is what counts for this PR

@andrewhsu andrewhsu merged commit f7aa41c into docker-archive:17.11 Oct 30, 2017
@andrewhsu andrewhsu deleted the sk branch October 30, 2017 23:57
cpuguy83 pushed a commit to cpuguy83/docker-ce that referenced this pull request Feb 7, 2018
…idfile

Add bash completion for `build --iidfile`
Upstream-commit: c394cd9bb75124fbcfd91b0dfdb9069d7958e20b
Component: cli
docker-jenkins pushed a commit that referenced this pull request Dec 3, 2018
[18.09] bump golang to 1.10.5
Upstream-commit: 47d440b14714e57f8cda9f042299db1d35b2b592
Component: packaging
docker-jenkins pushed a commit that referenced this pull request Jun 18, 2019
…ing_network_error

[19.03 backport] Handle the error case when a container reattaches to the same network
Upstream-commit: da6dddcd0473f91541759b36cfd0db7495fa8ffe
Component: engine
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants