Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

@andrewhsu
Copy link
Contributor

@andrewhsu andrewhsu commented Jul 11, 2017

Re-vndr containerd to docker-archive/containerd@6e23458

$ cd components/engine
$ make BIND_DIR=. shell
$ vndr github.com/containerd/containerd
2017/07/11 07:14:44 Collecting initial packages
2017/07/11 07:14:44 Download dependencies
2017/07/11 07:14:45     Clone https://github.com/docker/containerd to github.com/containerd/containerd, revision 6e23458c129b551d5c9871e5174f6b1b7f6d1170
2017/07/11 07:14:47     Finished clone github.com/containerd/containerd
2017/07/11 07:14:47 Dependencies downloaded. Download time: 1.549271645s
2017/07/11 07:14:47 Collecting all dependencies
2017/07/11 07:14:56 Clean vendor dir from unused packages
2017/07/11 07:14:56 Success
2017/07/11 07:14:56 Running time: 11.911349402s

To bring in changes from:

Note: there were 3 files that were deleted as a result of the vndr command:

        deleted:    vendor/github.com/spf13/cobra/doc/man_docs.go
        deleted:    vendor/github.com/spf13/cobra/doc/md_docs.go
        deleted:    vendor/github.com/spf13/cobra/doc/util.go

But I decided to leave them out of this PR. Will address in a separate PR.

@andrewhsu
Copy link
Contributor Author

@tiborvass we should watch out for conflicts with PR #102 runtime spec fix

@andrewhsu
Copy link
Contributor Author

Hmm...some tests failing:

00:12:33.343 [init] vendor/github.com/containerd/containerd/runtime/container_linux.go:115: cannot use i64Ptr(r.Memory) (type *int64) as type *uint64 in field value
00:12:33.343 [init] vendor/github.com/containerd/containerd/runtime/container_linux.go:116: cannot use i64Ptr(r.MemoryReservation) (type *int64) as type *uint64 in field value
00:12:33.343 [init] vendor/github.com/containerd/containerd/runtime/container_linux.go:117: cannot use i64Ptr(r.MemorySwap) (type *int64) as type *uint64 in field value
00:12:33.343 [init] vendor/github.com/containerd/containerd/runtime/container_linux.go:118: cannot use i64Ptr(r.KernelMemory) (type *int64) as type *uint64 in field value
00:12:33.343 [init] vendor/github.com/containerd/containerd/runtime/container_linux.go:119: cannot use i64Ptr(r.KernelTCPMemory) (type *int64) as type *uint64 in field value

@andrewhsu
Copy link
Contributor Author

Looks like this PR build test is failing because I forgot to update components/engine/hack/dockerfile/binaries-commits with corresponding gitcommit for containerd.

I'm going to close this issue anyways because this is just a subset of changes that is already taken care of in PR #102 [17.06] Runtime spec fix

@andrewhsu andrewhsu closed this Jul 12, 2017
@andrewhsu andrewhsu deleted the backport-containerd-fixes branch August 23, 2018 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant