Add config file support and move previews setting from manifest #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created DnvmConfig.cs with JSON serialization - Config file respects XDG spec on Linux (~/.config/dnvm/) - Moved PreviewsEnabled from manifest to config - Removed --enable-dnvm-previews flag - Updated help text and tests - Migration path from old manifests to config file Co-authored-by: agocke <[email protected]>
- Updated DnvmRunner to pass test config directory via environment variable - Fixed UpdateTests and SelfInstallTests to use test config directory - All tests now passing (157 unit tests, 17 integration tests) Co-authored-by: agocke <[email protected]>
Copilot
AI
changed the title
[WIP] Add support for a config file and move functionality
Add config file support and move previews setting from manifest
Nov 8, 2025
Copilot finished work on behalf of
agocke
November 8, 2025 21:50
agocke
reviewed
Nov 9, 2025
| if (!config.PreviewsEnabled) | ||
| { | ||
| // Migrate the setting to the config file | ||
| DnvmConfigFile.Write(config with { PreviewsEnabled = true }); |
Collaborator
There was a problem hiding this comment.
@copilot Please remove this -- we don't want to support writing config files right now
Contributor
Author
There was a problem hiding this comment.
Removed the automatic migration code in commit 9dfc5fe. Users will now need to manually create and edit the config file.
agocke
reviewed
Nov 9, 2025
Per feedback, removed the automatic migration code that would write to the config file when reading old manifests. Users will need to manually create/edit the config file instead. Co-authored-by: agocke <[email protected]>
Copilot finished work on behalf of
agocke
November 9, 2025 22:08
Copilot finished work on behalf of
agocke
November 9, 2025 22:11
agocke
reviewed
Nov 9, 2025
src/dnvm/DnvmConfig.cs
Outdated
| /// Get the platform-specific config directory path. | ||
| /// - Linux: ~/.config/dnvm/ (XDG_CONFIG_HOME/dnvm) | ||
| /// - macOS: ~/Library/Application Support/dnvm/ | ||
| /// - Windows: %LOCALAPPDATA%/dnvm/ |
Collaborator
There was a problem hiding this comment.
@copilot Configuration data should not be local by default -- I think this should be AppData
Contributor
Author
There was a problem hiding this comment.
Changed to use ApplicationData in commit 8f70456. Config files now use roaming app data: %APPDATA% on Windows and ~/.config on macOS/Linux.
Changed config location to use roaming application data: - Windows: %APPDATA% instead of %LOCALAPPDATA% - macOS: ~/.config instead of ~/Library/Application Support - Linux: unchanged (~/.config) This is more appropriate for configuration files that can be synced across machines. Co-authored-by: agocke <[email protected]>
Copilot finished work on behalf of
agocke
November 9, 2025 22:34
agocke
reviewed
Nov 11, 2025
src/dnvm/DnvmConfig.cs
Outdated
| /// <summary> | ||
| /// Static methods for config file operations. | ||
| /// </summary> | ||
| public static class DnvmConfigFile |
Collaborator
There was a problem hiding this comment.
@copilot Let's make this a class with instance methods
Contributor
Author
There was a problem hiding this comment.
Refactored to use instance methods in commit 8c42896. DnvmConfigFile is now a class that can be instantiated and used with instance methods.
Changed DnvmConfigFile from a static class to a regular class with instance methods. This provides better testability and follows standard OOP patterns. Usage changes: - Before: var config = DnvmConfigFile.Read(); - After: var configFile = new DnvmConfigFile(); var config = configFile.Read(); Co-authored-by: agocke <[email protected]>
Copilot finished work on behalf of
agocke
November 11, 2025 02:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement config file support and move "use previews" functionality to config file
Summary:
This PR adds a dedicated config file for dnvm settings and migrates the "use previews" functionality from the manifest to this config file. The config file respects platform-specific conventions for configuration storage.
Changes:
~/.config/dnvm/(respects XDG_CONFIG_HOME)~/.config/dnvm/%APPDATA%/dnvm/PreviewsEnabledsetting from manifest to config file--enable-dnvm-previewscommand-line flag (users manually editdnvmConfig.json)PreviewsEnabledfrom config instead of manifestUser Impact:
Users who want to enable preview releases will need to manually create the appropriate config file for their platform and set
"previewsEnabled": true. This provides a cleaner separation and follows platform conventions for roaming configuration data.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.