improve cell navigation with arrow keys #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CapPow
commented
Aug 9, 2018
CapPow
commented
- This PR attempts to improve the current cell navigation when using arrow keys.
- Since this modifies the way visible cells are determined, please test changes before merging.
|
can you please also check about findText as it doesnt opens any dialog box and neither appears into frame? in the core file? |
Author
|
@TarzanWonder, before I knew @dmnfarrell was already working on your request I took a stab at it. I placed it on a separate branch so as not to complicate this PR. If you're interested in my go at it, is at: https://github.com/CapPow/pandastable/commits/search_Replace |
|
@CapPow Sure i would love to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.