-
Notifications
You must be signed in to change notification settings - Fork 41
Add tests for imports with no prefix #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
hey @opatrascoiu - a few notes so far: //// Decision decision002 in 1158-noname-imports-03-A.dmn has an expression with a typeref of string, but the decision has no typeref. Perhaps best to remove the string typeref from the expression 7.3.1 Expression metamodel "If an instance of Expression that defines the output of a Decision element includes a typeRef, the referenced type SHALL be the same as the type of the containing Decision element." I'm left wondering when a conflict can occur. Take this modified example from the above test suite., It now points at an imported BKM ... There IS a bkm called I think this does not apply to imported types ... because they not namespaced ... they use the import name as a prefix (if I recall) ... and now there is none .... So, in that sense imported type name collisions are conceptually different to DRG element name collisions .. ? |
|
@StrayAlien Regarding 1158-noname-imports-03-A.dmn you are right, just pushed a fix. Regarding 1158-noname-imports-03-B.dmn, I noticed the issue a while back and fixed in the second commit. Please update your copy. |
|
@dmn-tck/contributors please review. |
|
@dmn-tck/contributors please review. This is an important topic, good to be merged as soon as possible so we can move focus on 1.6. |
|
@opatrascoiu Can you please rebase with master? |
This PR contains fixes for #674 as per discussion in the DMN RTF: