Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

fix bug in utils.py#163

Merged
szha merged 1 commit intodmlc:masterfrom
ThomasDelteil:patch-2
Jun 25, 2018
Merged

fix bug in utils.py#163
szha merged 1 commit intodmlc:masterfrom
ThomasDelteil:patch-2

Conversation

@ThomasDelteil
Copy link
Contributor

Description

When running run_all.sh got a bug:

    context = [mx.gpu(int(i)) for i in args.gpu]
TypeError: 'int' object is not iterable

Could be worth adding run_all.sh to the CI. Also, could results-vocablimit.csv be added to the repository?

@ThomasDelteil ThomasDelteil requested a review from szha as a code owner June 24, 2018 04:13
@mli
Copy link
Member

mli commented Jun 24, 2018

Job PR-163/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-163/1/index.html

@szha szha requested a review from leezu June 25, 2018 00:14
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@szha szha merged commit 53f1992 into dmlc:master Jun 25, 2018
@leezu
Copy link
Contributor

leezu commented Jun 25, 2018

Thanks @ThomasDelteil . Currently the CI doesn't have capacity for long-running jobs. I'm happy to track the results in the repo. I'll add that to #159

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants