This repository was archived by the owner on Jan 15, 2024. It is now read-only.
[BUGFIX] fix valid candidates issue#1323
Merged
sxjscience merged 3 commits intodmlc:masterfrom Sep 1, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
==========================================
+ Coverage 84.14% 84.23% +0.08%
==========================================
Files 42 42
Lines 6397 6426 +29
==========================================
+ Hits 5383 5413 +30
+ Misses 1014 1013 -1
Continue to review full report at Codecov.
|
sxjscience
reviewed
Aug 28, 2020
Member
|
@liuzh91 Would you try to fix this along with the other Gumbel-topk issue? (So there is no need for me to merge twice). |
Contributor
Author
OK, I'll work on that |
sxjscience
approved these changes
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the dynamic mask sampling strategy. Fix Issue #1321
Checklist
Essentials
Changes
Comments
cc @dmlc/gluon-nlp-team