[BUGFIX] Remove test set from validation

[avinashsai]

Fixes #372

[mli]

Job PR-1228/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1228/1/index.html

[codecov]

Codecov Report

Merging #1228 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1228   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          81       81           
  Lines        7365     7365           
=======================================
  Hits         6441     6441           
  Misses        924      924           

[avinashsai]

@leezu @szha Please review this

[eric-haibin-lin]

We still need the functionality to get test score for GNMT. For transformer, we have that in the infer_transformer.py. Can we add an option in train_gnmt that only does inference on the test set?

[avinashsai]

Similarly, an argument should be added in train_transformer.py whether to perform inference on test set? It should be default set to true?

[eric-haibin-lin]

No, no need to add that option to train_transformer.py since we already have a dedicated script for transformer inference

[avinashsai]

@StrayBird-ATSH GluonNLP-py3-master-gpu-doc is failing.

[chenw23]

Thanks for reminding. I have noticed it on some other pull request. It might be due to some global internet connectivity failures. We are sorting out reasons.

[avinashsai]

@StrayBird-ATSH Any updated on this?

[avinashsai]

@StrayBird-ATSH can you restart builds to see if the issue has been resolved?

[chenw23]

OK. I will have a look into it.

[avinashsai]

@StrayBird-ATSH I guess the error is fixed. If possible, can you restart builds?

[chenw23]

@StrayBird-ATSH I guess the error is fixed. If possible, can you restart builds?

Yes, would you please merge the latest master branch into your pull request, especially to include #1236 ?
Thanks!

[mli]

Job PR-1228/10 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1228/10/index.html

[avinashsai]

@eric-haibin-lin please review this

[eric-haibin-lin]

thanks for the contribution!