Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

[BUGFIX] Fix vocab determinism in py35 (#1166)#1167

Merged
leezu merged 2 commits intodmlc:v0.9.xfrom
eric-haibin-lin:vocab
Feb 25, 2020
Merged

[BUGFIX] Fix vocab determinism in py35 (#1166)#1167
leezu merged 2 commits intodmlc:v0.9.xfrom
eric-haibin-lin:vocab

Conversation

@eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Feb 22, 2020

Description

Backport #1166

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@eric-haibin-lin eric-haibin-lin requested a review from a team as a code owner February 22, 2020 07:44
@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #1167 into v0.9.x will increase coverage by 6.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.9.x    #1167      +/-   ##
==========================================
+ Coverage   81.93%   88.51%   +6.57%     
==========================================
  Files          72       72              
  Lines        6976     6976              
==========================================
+ Hits         5716     6175     +459     
+ Misses       1260      801     -459
Impacted Files Coverage Δ
src/gluonnlp/model/transformer.py 91.66% <0%> (+0.32%) ⬆️
src/gluonnlp/model/attention_cell.py 91.06% <0%> (+0.55%) ⬆️
src/gluonnlp/data/batchify/batchify.py 95.27% <0%> (+0.78%) ⬆️
src/gluonnlp/data/transforms.py 83.05% <0%> (+1.66%) ⬆️
src/gluonnlp/model/bert.py 94.62% <0%> (+2.98%) ⬆️
src/gluonnlp/data/datasetloader.py 85.34% <0%> (+3.01%) ⬆️
src/gluonnlp/data/corpora/wikitext.py 100% <0%> (+5.17%) ⬆️
src/gluonnlp/model/parameter.py 100% <0%> (+8%) ⬆️
src/gluonnlp/data/dataset.py 98.63% <0%> (+10.2%) ⬆️
src/gluonnlp/data/word_embedding_evaluation.py 89.31% <0%> (+16.41%) ⬆️
... and 7 more

@mli
Copy link
Member

mli commented Feb 25, 2020

Job PR-1167/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1167/2/index.html

@leezu leezu merged commit 50e5278 into dmlc:v0.9.x Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants