Add #[SkipStaticDatabaseConnection] attribute#339
Merged
Conversation
196a006 to
46a62fd
Compare
|
I have successfully tested the attribute in one application by requiring this branch via Composer: composer require --dev dama/doctrine-test-bundle dev-add_skip_attributeMy application uses #[SkipStaticDatabaseConnection]
class MyPantherTest extends PantherTestCase
{
use ResetDatabase;
...
}The attribute works as expected for me on both classes and methods. |
46a62fd to
52e63a6
Compare
|
Since the methods are |
Owner
Author
What would you suggest? I released it already but chances are low someone used it already. So I could still rename it. I don't have any strong opinion on the name 🤷♂️ edit: removed the release for now. So we can discuss it further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to skip the transactional database connection logic for individual tests by adding
#[SkipStaticDatabaseConnection]to a test class or method.Closes #182
Todos:
SkipStaticDatabaseConnectiona good name for the attribute?