Properly disable package-lock.json #815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks but having this file gives up reproducible builds. |
Contributor
Author
|
Err what are you talking about? You don't have a lock file commited...
…On Mon, Oct 4, 2021, 11:47 Michael Mifsud ***@***.***> wrote:
Closed #815 <#815>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#815 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNNMKYFXRK4H7PPM3MTUFFZ4FANCNFSM5FISNS3Q>
.
|
Contributor
Author
|
This PR does not change the existent behavior. It simply properly disables
the lock file.
If you want a lock file, that's OK, but it's not the case on master.
So, if you are going to add a lock file, I should also update my CI PR to
use npm ci. Otherwise this patch is good to go.
…On Mon, Oct 4, 2021, 11:48 XhmikosR ***@***.***> wrote:
Err what are you talking about? You don't have a lock file commited...
On Mon, Oct 4, 2021, 11:47 Michael Mifsud ***@***.***>
wrote:
> Closed #815 <#815>.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#815 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AACVLNNMKYFXRK4H7PPM3MTUFFZ4FANCNFSM5FISNS3Q>
> .
>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.