dtoh: Hide checkbuf behind a dedicated debug condition #12661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids a redundant call to toDstring for every included symbol
Some asserts were generated in a non-debug build but discarded at the end because `checkbuf` wasn't included in the final header. Hiding all validation logic behind a dedicated `debug` condition stops this waste of time/memory and and lets one enable those `assert´s without the logging.
Contributor
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12661" |
thewilsonator
approved these changes
Jun 9, 2021
RazvanN7
approved these changes
Jun 9, 2021
UplinkCoder
pushed a commit
to UplinkCoder/dmd
that referenced
this pull request
Aug 19, 2021
* dtoh: Pass temporary buffer instead of C string Avoids a redundant call to toDstring for every included symbol * dtoh: Hide checkbuf behind a dedicated debug condition Some asserts were generated in a non-debug build but discarded at the end because `checkbuf` wasn't included in the final header. Hiding all validation logic behind a dedicated `debug` condition stops this waste of time/memory and and lets one enable those `assert´s without the logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some asserts were generated in a non-debug build but discarded at the
end because
checkbufwasn't included in the final header.Hiding all validation logic behind a dedicated
debugconditionstops this waste of time/memory and and lets one enable those
assertswithout the logging.