[WIP] Move A11yBridge to FVC #32

dkwingsmt · 2023-01-18T20:38:29Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…necessary (flutter#38965) * draft fix rename unittest * update scenario * test

…er#38990) https://dart.googlesource.com/sdk.git/+log/645fd748e79e..ddf70a598f27 2023-01-18 [email protected] Version 3.0.0-136.0.dev 2023-01-18 [email protected] Version 3.0.0-135.0.dev 2023-01-18 [email protected] Version 3.0.0-134.0.dev 2023-01-17 [email protected] Version 3.0.0-133.0.dev 2023-01-17 [email protected] Version 3.0.0-132.0.dev 2023-01-17 [email protected] Version 3.0.0-131.0.dev 2023-01-17 [email protected] Version 3.0.0-130.0.dev 2023-01-17 [email protected] Version 3.0.0-129.0.dev 2023-01-16 [email protected] Version 3.0.0-128.0.dev 2023-01-16 [email protected] Version 3.0.0-127.0.dev 2023-01-16 [email protected] Version 3.0.0-126.0.dev 2023-01-13 [email protected] Version 3.0.0-125.0.dev 2023-01-13 [email protected] Version 3.0.0-124.0.dev 2023-01-13 [email protected] Version 3.0.0-123.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#38994) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

flutter#39004) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Use AXFragmentRootWin for MSAA functionality. Some unused code remains to be removed. Merge MSAA to AXFragmentRootWin * Removing unused code * Remove unused files * Flip macro * Formatting * Licenses * Make reference * Disable copy constructor/assignment * Unused import * Formatting * Relocate alert logic * Remove comment and unused mock * Fix unit test * Idempotency * Formatting * PR feedback * Doc comments * Undo string change for now * Couple fragment root and alert node * Formatting * Add comments * Pointer to reference * Typo fix

…lutter#38998)

…6512) Flutter locales use the BCP-47 format (https://www.rfc-editor.org/rfc/bcp/bcp47.txt), and Unix locales use a POSIX format. There is not a perfect mapping between them, see https://wiki.openoffice.org/wiki/LocaleMapping The current implementation is not correctly setting the appropriate optional fields, so remove that. There are likely some Unix locales that should set these fields, but these are best fixed by adding special cases for them as they are discovered. Fixes: flutter/flutter#111341

) https://skia.googlesource.com/skia.git/+log/69d8378097df..aedfc8695954 2023-01-17 [email protected] [graphite] Fix Dawn validation error due to hasDynamicOffset=true. 2023-01-17 [email protected] [graphite] Enable depth & stencil formats' support in DawnCaps 2023-01-17 [email protected] [graphite] Create graphite::Image_Base 2023-01-17 [email protected] update libwebp to 1.3.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Extract WideToUTF16String/UTF16StringToWide to FML In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811 * Migrate UTF16ToWide as well

…9006)" (flutter#39019) This reverts commit 7bbe79e.

…o elide a restore (flutter#39023)

…9024) https://skia.googlesource.com/skia.git/+log/aedfc8695954..1b3aa8b6e1cc 2023-01-19 [email protected] [base] Move more files into base 2023-01-19 [email protected] Roll ANGLE from bf5a007afc1f to e960355a9a22 (7 revisions) 2023-01-19 [email protected] Manual Dawn roll from e1ad5c39e1d7 to 7e02157df528 (9 revisions) 2023-01-19 [email protected] Revert "Add setters for providing client info to SkParagraphBuilder" 2023-01-19 [email protected] Revert "Correct ParagraphBuilder::getText() behavior" 2023-01-19 [email protected] Make SK_API visible to user config file 2023-01-19 [email protected] Roll vulkan-deps from bd5634fbaca7 to 823d1a0d7c30 (9 revisions) 2023-01-19 [email protected] Roll ANGLE from 5d1ac2e0d5f6 to bf5a007afc1f (10 revisions) 2023-01-19 [email protected] Roll Skia Infra from a42938f058cb to d27950c1863f (4 revisions) 2023-01-18 [email protected] Fix an off-by-one in the max index passed to glDrawRangeElements by DrawMeshOp 2023-01-18 [email protected] Allow SkUserConfig.h to override SkAttributes.h 2023-01-18 [email protected] Correct ParagraphBuilder::getText() behavior 2023-01-18 [email protected] [graphite] Have onMakeSubset and onMakeTextureImage share code 2023-01-18 [email protected] Roll vulkan-deps from 61e7733b455d to bd5634fbaca7 (9 revisions) 2023-01-18 [email protected] Move SK_CODEC_DECODES_JPEG_GAINMAPS from defines to public_defines 2023-01-18 [email protected] Roll SK Tool from 9f0f02bea4b2 to 3e5659852fc3 2023-01-18 [email protected] Add setters for providing client info to SkParagraphBuilder 2023-01-18 [email protected] Add RP codegen support for out/inout parameters. 2023-01-18 [email protected] Very small clean up in SkScalerCache 2023-01-18 [email protected] Simplify redundant pop-push pairs. 2023-01-18 [email protected] Fix stack-rewind test. 2023-01-18 [email protected] [base] Move more files into base 2023-01-18 [email protected] Remove SkMath.h from the public API 2023-01-18 [email protected] Coalesce adjacent calls to copy_stack_from_slots. 2023-01-18 [email protected] Coalesce adjacent calls to push_uniforms. 2023-01-18 [email protected] Coalesce adjacent calls to push_slots. 2023-01-18 [email protected] Eliminate pushes that are immediately discarded. 2023-01-18 [email protected] [graphite] Fix onMakeSubset optimization 2023-01-18 [email protected] Breaking down Copy ReorderVisuals (4) 2023-01-18 [email protected] Avoid exporting libandroidicu headers 2023-01-18 [email protected] SkJpegCodec: Add JpegR gainmap extraction support 2023-01-18 [email protected] Generate SkRP golden outputs from test files. 2023-01-18 [email protected] Disable MatrixEquality test on Tegra3. 2023-01-18 [email protected] SkJpegCodec: Fix compound metadata index validation 2023-01-18 [email protected] Remove SK_DISABLE_RASTER_PIPELINE_SAMPLING_FIXES 2023-01-18 [email protected] Remove dependency on SkRasterPipeline from SkOpts. 2023-01-18 [email protected] jpegr codec: create color profile from ICCProfile data 2023-01-18 [email protected] Rename SkAutoTArray -> AutoTArray and move to skia_private 2023-01-18 [email protected] bazel: Add script to obtain the MacSDK symlink directory. 2023-01-18 [email protected] Roll vulkan-deps from 685cc71cd840 to 61e7733b455d (5 revisions) 2023-01-18 [email protected] Roll ANGLE from 734cf7ce212f to 5d1ac2e0d5f6 (8 revisions) 2023-01-18 [email protected] Roll Skia Infra from dc43f9a8e874 to a42938f058cb (6 revisions) 2023-01-18 [email protected] Roll Dawn from cd6104d0f0a1 to e1ad5c39e1d7 (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…9027) https://skia.googlesource.com/skia.git/+log/1b3aa8b6e1cc..f6a5c806294d 2023-01-20 [email protected] Roll SK Tool from 3e5659852fc3 to dddaffde005d 2023-01-20 [email protected] Remove getUnderlyingStrike 2023-01-20 [email protected] [graphite] Enable AnalyticRRectRenderStep for fills 2023-01-20 [email protected] Roll vulkan-deps from 823d1a0d7c30 to 37a74218c401 (10 revisions) 2023-01-20 [email protected] Build all outputs when skia_compile_sksl_tests is enabled. 2023-01-20 [email protected] Remove SkAutoSTArray and SkAutoSTMalloc 2023-01-20 [email protected] Rename SkAutoSTArray -> AutoSTArray and move to skia_private 2023-01-20 [email protected] Add SkGainmapShader 2023-01-20 [email protected] Fix line formatting when maxWidth == INF && align == kJustify && textDirection == kLtr 2023-01-20 [email protected] Eliminate unnecessary return-mask operations. 2023-01-20 [email protected] Change SkSRGBGammaColorFilter to SkColorSpaceXformColorFilter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#39029) https://dart.googlesource.com/sdk.git/+log/ddf70a598f27..fbbfc122dba6 2023-01-20 [email protected] Version 3.0.0-145.0.dev 2023-01-20 [email protected] Version 3.0.0-144.0.dev 2023-01-19 [email protected] Version 3.0.0-143.0.dev 2023-01-19 [email protected] Version 3.0.0-142.0.dev 2023-01-19 [email protected] Version 3.0.0-141.0.dev 2023-01-19 [email protected] Version 3.0.0-140.0.dev 2023-01-19 [email protected] Version 3.0.0-139.0.dev 2023-01-19 [email protected] Version 3.0.0-138.0.dev 2023-01-18 [email protected] Version 3.0.0-137.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) * [macos] Synthesize modifier keys events on pointer events * Move test to FlutterViewControllerTest * Simplify by using 'for in' Co-authored-by: Bruno Leroux <[email protected]>

…#39030) https://dart.googlesource.com/sdk.git/+log/fbbfc122dba6..ac4c63168ff2 2023-01-20 [email protected] Version 3.0.0-146.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#39032) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

…#39036) https://dart.googlesource.com/sdk.git/+log/ac4c63168ff2..03d35455a8d8 2023-01-20 [email protected] Version 3.0.0-147.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#39038)

…#39042) https://dart.googlesource.com/sdk.git/+log/03d35455a8d8..807077cc5d1b 2023-01-20 [email protected] Version 3.0.0-148.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er#38169)

* [Impeller] Add and reorder FAQ entries. * Update impeller/docs/faq.md Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Loïc Sharma <[email protected]>

* Clarify messenger APIs * Feedback

…... (flutter#39107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…9108) https://skia.googlesource.com/skia.git/+log/1bc48bcb1201..b72fececbdcc 2023-01-24 [email protected] Roll Dawn from 6c8aa8aff9d1 to f0d8edecee77 (6 revisions) 2023-01-24 [email protected] remove skottie from Android.bp 2023-01-24 [email protected] Reland "Correct ParagraphBuilder::getText() behavior" 2023-01-24 [email protected] Allow SK_TRIVIAL_ABI to be configured 2023-01-24 [email protected] Roll vulkan-deps from a2f348c2039f to ab6fd1e74de0 (4 revisions) 2023-01-24 [email protected] Roll Dawn from ffe356d558bc to 6c8aa8aff9d1 (12 revisions) 2023-01-24 [email protected] Reland "Add setters for providing client info to SkParagraphBuilder" 2023-01-24 [email protected] jpegr codec: Implement scanline decoding and sampling 2023-01-24 [email protected] Rename SkAutoFree -> UniqueVoidPtr and move to private 2023-01-24 [email protected] [graphite] Add unit test for makeColorTypeAndColorSpace 2023-01-24 [email protected] SkJpegSegmentScanner: Use state-machine based scan 2023-01-24 [email protected] Add recovery steps for scaling and disabling cpu cores. 2023-01-24 [email protected] Roll vulkan-deps from f93afca731ce to a2f348c2039f (3 revisions) 2023-01-24 [email protected] Fix correctness issue with SkImageImageFilter and unpremul images If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…scale only (flutter#39112)

) https://skia.googlesource.com/skia.git/+log/b72fececbdcc..8ffd5c20d634 2023-01-24 [email protected] [sksl][wgsl] Support for trivial ternary expressions 2023-01-24 [email protected] Create a BranchCtx for Raster Pipeline branch ops. 2023-01-24 [email protected] Roll Dawn from f0d8edecee77 to c744a23d77d5 (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#39122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) https://skia.googlesource.com/skia.git/+log/8ffd5c20d634..da5034f9d117 2023-01-25 [email protected] Roll ANGLE from 9a72a98eb94f to 660e4a7c0d4f (4 revisions) 2023-01-25 [email protected] Roll Dawn from c744a23d77d5 to bb0229002db5 (5 revisions) 2023-01-25 [email protected] Roll Skia Infra from d7a3d7db7fde to 8666a7bf5e4a (8 revisions) 2023-01-25 [email protected] Roll vulkan-deps from ab6fd1e74de0 to 71bd1907ea2f (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#38573) * [web] use a render target instead of a new surface for Picture.toImage * setup grcontext if missing * ++ * dispose * Add unit test for MakeRenderTarget * ++ * ++ * ++ * ++ * ++ * ++ * ++

https://skia.googlesource.com/skia.git/+log/da5034f9d117..c4b171fe5668 2023-01-25 [email protected] Add SkJpegGainmapEncoder::EncodeJpegR and EncodeHDRGM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…... (flutter#39130) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#39119)

Cannot build log URL because revision "2cce76fd67af" is invalid: revision "2cce76fd67afce170560afaaac1872efefe64fdb" doesn't match expected revision "2c51e5cc7e0a06cd4cd7cb2ddbac445af9b475ba" obtained from https://fuchsia.googlesource.com/integration/+/refs/heads/main/third_party/icu 2023-01-12 [email protected] Revert "[config] Declare the args conditionally" 2023-01-12 [email protected] Revert "[fuchsia] Limit the visibility of ICU targets" 2022-12-13 [email protected] Update TZ to 2022g 2022-12-09 [email protected] [fuchsia] Limit the visibility of ICU targets 2022-12-07 [email protected] [config] Declare the args conditionally If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/icu-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ICU: https://github.com/unicode-org/icu To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Fix position of ImageFilter layer when raster-cached * Move integral transform and add tests * Don't round in Preroll

) https://skia.googlesource.com/skia.git/+log/c4b171fe5668..393fb1ec80f4 2023-01-25 [email protected] Remove unnecessary use of SkOverrideDeviceMatrixProvider 2023-01-25 [email protected] Revert "Add SkJpegGainmapEncoder::EncodeJpegR and EncodeHDRGM" 2023-01-25 [email protected] Roll vulkan-deps from 71bd1907ea2f to ba538cd033e4 (2 revisions) 2023-01-25 [email protected] Roll SK Tool from a101f5006435 to d23b977e964d 2023-01-25 [email protected] [canvaskit] Control trivial_abi in compile_gm.sh 2023-01-25 [email protected] remove unused config groups in sk_app Bazel BUILD file 2023-01-25 [email protected] Make memory accounting go through SkStrike 2023-01-25 [email protected] [base] Add extra tests for cubic and quadratic root solving 2023-01-25 [email protected] Fixing broken Android autoroll If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Enable Vulkan to be developed on macOS host * Disables modern features as SSBOs are wired on Vulkan yet. * Sub-optimal presentation mode must not be a fatal issue. * Allow for shader outputs not to be consumed. * remove enabling macOS

…ohibit replacing (flutter#38981) This PR adds FlutterViewController.id, and formalizes how FlutterViewController is initialized by FlutterEngine: When FlutterViewController is set to the engine, the engine calls FlutterViewController#attachToEngine:withId:. When FlutterViewController is unset from the engine, the engine calls FlutterViewController#detachFromEngine. This allows the ID to be generated by the engine. The default View ID is now 1 instead of 0. In this way, we can use 0 as an empty value, the value for FlutterViewController.id when the FVC is not attached to an engine. (IDs are meant to be opaque, and views should be a map, not an array anyway.) This PR moves almost all initialization code into FVC's CommonInit to ensure that all init path produces the expected result. With this PR, FlutterEngine no long supports replacing viewController (from non-null to a different non-null). Setting the view controller (from null to non-null) is intended to allow pre-warming an engine before displaying it in add-to-app, but replacing the view controller does not make much sense. If the developer wants to persist the state of the view between different windows, they could just attach the view controller to different windows. In fact, Flutter doesn't even have a way to create a FlutterViewController that is unattached to an engine. All initializers either require an engine or create an engine. As a result, unit tests that used to create FVC with the wrong initializer are fixed.

…, and prohibit replacing (flutter#38981)" (flutter#39144) This reverts commit e3b2782.

See flutter/flutter#119170

…, and prohibit replacing" (flutter#39145) * Revert "Revert "[macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing (flutter#38981)" (flutter#39144)" This reverts commit 36db005. * Fix?

kjlubick and others added 2 commits January 18, 2023 09:58

Remove use of SkTAddOffset and sk_careful_memcpy (flutter#38977)

2722c54

Get unit tests working with dart2wasm (flutter#38784)

290636c

dkwingsmt mentioned this pull request Jan 18, 2023

[macOS] Move A11yBridge to FVC flutter/engine#38855

Merged

8 tasks

Chris Yang and others added 27 commits January 18, 2023 22:19

[ios_platform_view] more precision when determine if a clip rrect is …

2a11023

…necessary (flutter#38965) * draft fix rename unittest * update scenario * test

Bump chrome_and_driver version to 110. (flutter#38986)

8ed6790

Remove references to Observatory (flutter#38919)

88e61d8

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

[web] dont look up webgl params if no GPU is available (flutter#38948)

78bbea0

Shader analysis with malioc (flutter#39005)

f2536ce

[Impeller] Account for the transform in DLVerticesGeometry coverage (f…

dd8c259

…lutter#38998)

Remove unused variables and import (flutter#38971)

26b6609

Revert "Extract WideToUTF16String/UTF16StringToWide to FML (flutter#3…

acca56c

…9006)" (flutter#39019) This reverts commit 7bbe79e.

[Impeller] Check the correct stencil coverage when deciding whether t…

730e88f

…o elide a restore (flutter#39023)

Extract WideToUTF16String/UTF16StringToWide to FML (flutter#39020)

d2436a5

[macos] Synthesize modifier keys events on pointer events (flutter#37870

ccccee5

) * [macos] Synthesize modifier keys events on pointer events * Move test to FlutterViewControllerTest * Simplify by using 'for in' Co-authored-by: Bruno Leroux <[email protected]>

Revert "Remove references to Observatory (flutter#38919)" (flutter#39035

58eb106

) Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

[impeller] correct input order in ColorFilterContents::MakeBlend (flu…

e2c2e50

…tter#39038)

Harry Terkelsen and others added 22 commits January 24, 2023 14:23

[web] Remove dependency on 'profiling' subfolder of canvaskit. (flutt…

acb5610

…er#38169)

[Impeller] Add and reorder FAQ entries. (flutter#39106)

d98926c

* [Impeller] Add and reorder FAQ entries. * Update impeller/docs/faq.md Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Loïc Sharma <[email protected]>

Improve crashes if messenger APIs are used incorrectly (flutter#39041)

4165d4b

* Clarify messenger APIs * Feedback

[Impeller] Switch to nearest sampling for the text atlas (flutter#39104)

5405f2c

Manually roll ANGLE, vulkan-deps, SwiftShader (flutter#38650)

f1464b4

[Impeller] Linear sample atlas glyphs when the CTM isn't translation/…

55bb8de

…scale only (flutter#39112)

[web] use a render target instead of a new surface for Picture.toImage (

6f80649

flutter#38573) * [web] use a render target instead of a new surface for Picture.toImage * setup grcontext if missing * ++ * dispose * Add unit test for MakeRenderTarget * ++ * ++ * ++ * ++ * ++ * ++ * ++

Only build analyze_snapshot on Linux host (flutter#39129)

c545801

Remove unnecessary null checks (flutter#39113)

2e7d6fa

[Impeller] Make text glyph offsets respect the current transform (flu…

30c02e4

…tter#39119)

Fix position of ImageFilter layer when raster-cached (flutter#38567)

44362c9

* Fix position of ImageFilter layer when raster-cached * Move integral transform and add tests * Don't round in Preroll

dkwingsmt force-pushed the a11y-multiview branch from 6023003 to 2bedd66 Compare January 25, 2023 22:43

dkwingsmt and others added 5 commits January 25, 2023 15:16

Revert "[macOS] Formalize FlutterViewController's initialization flow…

36db005

…, and prohibit replacing (flutter#38981)" (flutter#39144) This reverts commit e3b2782.

Roll buildroot (flutter#39141)

a206091

See flutter/flutter#119170

[Impeller] Use analytical normals for stroke caps (flutter#39124)

c068a36

Rebase all

554220a

dkwingsmt force-pushed the a11y-multiview branch from c063d9f to 554220a Compare January 26, 2023 00:28

dkwingsmt closed this Jan 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Move A11yBridge to FVC #32

[WIP] Move A11yBridge to FVC #32

Uh oh!

dkwingsmt commented Jan 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

[WIP] Move A11yBridge to FVC #32

[WIP] Move A11yBridge to FVC #32

Uh oh!

Conversation

dkwingsmt commented Jan 18, 2023

Pre-launch Checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants