Ignore duplicates #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed from the Scaffold's interface in oshop, so we can remove it here.
As check_payment_outcome was removed, the record_audit_trail kwarg was always true. So we can remove it for simplicity.
Adyen duplicates many notifications. Luckily, our audit trail gives us an easy way to check for duplicates. We ignore duplicated notifications, but acknowledge them nonetheless.
maiksprenger
force-pushed
the
feature/ignore-duplicates
branch
from
514f9e9 to
956eaaf
Compare
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things. It mirrors changes in the scaffold interface that is done on oshop, by removing
get_payment_outcome.Adyen may duplicate notifications. The simplification of the scaffold interface means we're confident we're always recording an audit trail, and can rely on that audit trail to ignore duplicated notifications. That's the second part of this PR.