-
Notifications
You must be signed in to change notification settings - Fork 494
Removed n+1 query from bulk_create_with_history utility #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed n+1 query from bulk_create_with_history utility #975
Conversation
|
Thanks for running the test build =D Kind of surprised it's failing so will take a look at reproducing by the end of the weekend 👍 |
|
I looked into the failing test build, the issue was some assertions which not exactly correct, and have now been fixed =) |
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
=======================================
Coverage 97.64% 97.65%
=======================================
Files 23 23
Lines 1147 1151 +4
Branches 222 222
=======================================
+ Hits 1120 1124 +4
Misses 12 12
Partials 15 15
Continue to review full report at Codecov.
|
Description
bulk_create_with_historywhich doesn't haveidsin response from database to consolidaten+1lookups into 1 lookupRelated Issue
This closes #974
Motivation and Context
For databases which lack ids in responses, there was a significant amount of additional queries being run. This resolves that issue by consolidating the number of queries
How Has This Been Tested?
Yes, please see changes in the test suite
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst