Support changeReason for bulk history create #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES.rst
Outdated
| ---------- | ||
| - Add ability to cascade delete historical records when master record is deleted | ||
| - Add ability to cascade delete historical records when master record is deleted | ||
| - Add `'+'` as the `history_type` for each instance in `bulk_history_create` |
There was a problem hiding this comment.
Just add this PR number next to the change please. i.e. (gh-449)
docs/reference.rst
Outdated
| >>> for poll in data: | ||
| poll.changeReason = 'reason' | ||
| >>> objs = bulk_create_with_history(data, Poll, batch_size=500) | ||
| >>> Poll.objects.get(id=data[0].id).history_change_reason |
There was a problem hiding this comment.
Wouldn't this have to be HistoricalPoll or Poll.history.get? I don't think there's a history_change_reason on the base instance
| self.model( | ||
| history_date=getattr(instance, '_history_date', now()), | ||
| history_user=getattr(instance, '_history_user', None), | ||
| history_change_reason=getattr(instance, 'changeReason', ''), |
|
Tests failed, which is why #447 will be awesome. Just a few questions around documentation of changeReason but overall lgtm |
rossmechanic
added
the
DjangoConUS2018
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 15 15
Lines 679 679
Branches 93 93
=======================================
Hits 661 661
Misses 9 9
Partials 9 9Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'+'as thehistory_typefor each instance inbulk_history_createhistory_change_reasonfor each instance inbulk_history_createRelated Issue
#442
Motivation and Context
This solves issue #442
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: