Skip to content

Conversation

@ddabble
Copy link
Member

@ddabble ddabble commented May 29, 2024

Description

Our code requires a Django installation to run, so it would make sense to add it as a dependency.

Related Issue

None.

Motivation and Context

See Description.

How Has This Been Tested?

GitHub Actions.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

Our code requires a Django installation to run, so it would make sense
to add it as a dependency.
@ddabble ddabble added the dependencies Pull requests that update a dependency file label May 29, 2024
@ddabble ddabble requested a review from tim-schilling May 29, 2024 16:29
@ddabble ddabble merged commit a4e4783 into django-commons:master May 29, 2024
@ddabble ddabble deleted the add-django-dependency branch May 29, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants