Add Django 5.0 #1289
Merged
Add Django 5.0 #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 23 23
Lines 1278 1278
Branches 211 211
=======================================
Hits 1238 1238
Misses 21 21
Partials 19 19 ☔ View full report in Codecov by Sentry. |
11 tasks
jonatkinson
previously approved these changes
Jan 26, 2024
Drop Django 4.1 Fixes #1283
3.13 can't be tested with postgres, as `psycopg2-binary` doesn't currently support 3.13 - see e.g. https://github.com/ddabble/django-simple-history/actions/runs/7937535510/job/21674900984. I still think it's better to add early support of 3.13 and temporarily test without postgres, since all the other packages (and our code) currently work with 3.13. Also bumped the Python version in `.readthedocs.yaml` to 3.12, as it's the latest, stable version available. Also removed the recently dropped Django 4.1 from `setup.py` and `tox.ini`, and added Django 5.0 to `setup.py`.
ddabble
dismissed stale reviews from jonatkinson and thesayfulla
via
607cdcc
ddabble
approved these changes
Feb 17, 2024
Member
ddabble
left a comment
ddabble
left a comment
There was a problem hiding this comment.
Looks good! Didn't find any additional changes to be made (as mentioned in this comment) :)
I also added early support of Python 3.13, even though it doesn't yet work with psycopg2-binary.
Thank you 😊
Member
|
Also thank you, @thesayfulla and @jonatkinson for reviewing! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the supported versions of Django.
Description
Adds support for 5.0
Drops support for 4.1
Related Issue
Fixes #1283
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst