fix: use gnu sed in shell tests for cross-platform compatibility#441
Conversation
Darwin's use of BSD `sed` breaks here because BSD `sed` has a different argument signature.
Pacman99
left a comment
Pacman99
left a comment
There was a problem hiding this comment.
LGTM
you should be able to bors r+
|
@Pacman99 I opted for a PR mainly to go through the exercise of learning about the CI/build process for PRs. |
|
bors r+ |
441: fix: use gnu sed in shell tests for cross-platform compatibility r=montchr a=montchr Darwin's use of BSD `sed` breaks here because BSD `sed` has a different argument signature. Spun off from #438 as suggested in #438 (comment) Co-authored-by: Chris Montgomery <[email protected]>
|
@Pacman99 anything in addition to the details in the bors getting started guide i should know about the process specific to divnix and digga? |
|
Build failed: |
|
Not that I can think of, i think you know everything about where checks are located. There is also bors try |
|
Strange that builds are hanging on this one… I cancelled the first run once it had been running for an hour. I stepped away and came back to find this build has been running for two hours… |
|
Yeah I'm not sure whats up with that 😕 And this PR doesn't change anything significant to change build times by that much |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
2 participants
Darwin's use of BSD
sedbreaks here because BSDsedhas a differentargument signature.
Spun off from #438 as suggested in #438 (comment)