Skip to content

Refactor and upgrade release-validation to perform a double-update#309

Merged
knuton merged 2 commits intodividat:mainfrom
yfyf:double-update-rel-validation
Feb 18, 2026
Merged

Refactor and upgrade release-validation to perform a double-update#309
knuton merged 2 commits intodividat:mainfrom
yfyf:double-update-rel-validation

Conversation

@yfyf
Copy link
Collaborator

@yfyf yfyf commented Jan 21, 2026

Note 1: using unsignedRaucBundle from releaseValidation components to ensure that the updated system has passwordless root. Needed for debugging purposes and to be able to cleanly restart the system(s) via TTY. More generally, this ensures that the bundles have the same same "mods" as the release disks.

Note 2: this incorporates the safe-TTY-reboot (606eaaf) from #307, but not the other CI / flakiness patches there. Should be added too, keeping this a draft until then. Rebased on top of main, done.

Note 3: in an ideal scenario, we would check that BASE->PRE reaches UpToDate and only then change latest to NEXT and do the second update, but I can't think of a way to do this that doesn't involve a manual controller restart or an extra reboot (or waiting for 1 hour), so we only check for UpToDate after the second update.

@yfyf yfyf added the reviewable Ready for initial or iterative review label Jan 21, 2026
@yfyf yfyf force-pushed the double-update-rel-validation branch 2 times, most recently from b6a2612 to e542041 Compare January 22, 2026 09:00
Note: using unsignedRaucBundle from releaseValidation components to
ensure that the updated system has passwordless root for debugging
purposes and to be able to cleanly restart the system via TTY.
@yfyf yfyf force-pushed the double-update-rel-validation branch from e542041 to 44fcad2 Compare January 22, 2026 09:10
@yfyf
Copy link
Collaborator Author

yfyf commented Jan 22, 2026

Ughhh, the double-update fails for older baseSystem versions, because their disks have been created with a persistent data partition that doesn't fit the bundle and fail while the second update is being downloaded.

Need to back-port #300 to earlier releases and rebuild the disks.

Otherwise everything seems to work: https://github.com/dividat/playos/actions/runs/21242598811

@knuton
Copy link
Member

knuton commented Jan 23, 2026

Ughhh, the double-update fails for older baseSystem versions, because their disks have been created with a persistent data partition that doesn't fit the bundle and fail while the second update is being downloaded.

Need to back-port #300 to earlier releases and rebuild the disks.

Should we reduce to only last release and see this through and keep an issue for the backporting and subsequent widening of automatic tests?

@knuton knuton added details needed Further information requested to better evaluate changes and removed reviewable Ready for initial or iterative review labels Jan 23, 2026
@yfyf
Copy link
Collaborator Author

yfyf commented Jan 26, 2026

Ughhh, the double-update fails for older baseSystem versions, because their disks have been created with a persistent data partition that doesn't fit the bundle and fail while the second update is being downloaded.
Need to back-port #300 to earlier releases and rebuild the disks.

Should we reduce to only last release and see this through and keep an issue for the backporting and subsequent widening of automatic tests?

I'll just backport it. It's easy to do and I would prefer to validate that the release-validation tests do work at least across a few generations, will make it easier to adapt them for the skeletons later on.

Also mention that release-validation tests will fail on non-rebuilt
ones.
@yfyf
Copy link
Collaborator Author

yfyf commented Feb 5, 2026

@yfyf yfyf marked this pull request as ready for review February 5, 2026 10:50
@yfyf yfyf added reviewable Ready for initial or iterative review and removed details needed Further information requested to better evaluate changes labels Feb 5, 2026
@yfyf yfyf requested a review from knuton February 17, 2026 12:27
@yfyf
Copy link
Collaborator Author

yfyf commented Feb 17, 2026

@knuton I somehow assumed you are already reviewer on this, but it seems you were unassigned.

Copy link
Member

@knuton knuton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@knuton knuton removed the reviewable Ready for initial or iterative review label Feb 18, 2026
@knuton knuton merged commit 31c687c into dividat:main Feb 18, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants