Skip to content

Conversation

@Jiralite
Copy link
Member

@Jiralite Jiralite commented Aug 4, 2025

Please describe the changes this PR makes and why it should be merged:
This makes template creation actually create a template.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Aug 4, 2025 9:47am
discord-js-guide ⬜️ Ignored (Inspect) Aug 4, 2025 9:47am

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.86%. Comparing base (c0c1ac2) to head (a43b9e3).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/api/guild.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11030      +/-   ##
==========================================
- Coverage   43.87%   43.86%   -0.01%     
==========================================
  Files         310      310              
  Lines       17777    17774       -3     
  Branches     1749     1748       -1     
==========================================
- Hits         7799     7797       -2     
+ Misses       9966     9965       -1     
  Partials       12       12              
Flag Coverage Δ
core 0.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a patch LOL

@Jiralite Jiralite changed the title feat(guild): Add creating a template fix(guild): Creating a template actually creates a template Aug 4, 2025
@Jiralite Jiralite marked this pull request as ready for review August 4, 2025 13:40
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Aug 4, 2025
@kodiakhq kodiakhq bot merged commit a2ee393 into main Aug 4, 2025
31 checks passed
@kodiakhq kodiakhq bot deleted the feat/guild-template-create branch August 4, 2025 18:46
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Aug 4, 2025
Jiralite added a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants