Skip to content

Conversation

@Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
According to https://discord.com/channels/222078108977594368/999796393810067607/1394843350040842302, validation should not be done for context menu commands.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite added this to the builders 2.0.0 milestone Jul 16, 2025
@Jiralite Jiralite requested a review from a team as a code owner July 16, 2025 07:40
@Jiralite Jiralite requested review from iCrawl and vladfrangu July 16, 2025 07:40
@Jiralite Jiralite requested review from didinele and kyranet July 16, 2025 07:40
@vercel
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2025 8:54am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2025 8:54am

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.42%. Comparing base (9ff0482) to head (ffe6552).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10994   +/-   ##
=======================================
  Coverage   44.42%   44.42%           
=======================================
  Files         308      308           
  Lines       17583    17585    +2     
  Branches     1748     1749    +1     
=======================================
+ Hits         7811     7813    +2     
  Misses       9759     9759           
  Partials       13       13           
Flag Coverage Δ
builders 79.98% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Jul 16, 2025
@kodiakhq kodiakhq bot merged commit 1dfc511 into main Jul 16, 2025
27 of 28 checks passed
@kodiakhq kodiakhq bot deleted the fix/context-validate-none branch July 16, 2025 15:47
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants