Skip to content

types(GuildSoundboardSoundEditOptions): add missing reason #10863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

types(GuildSoundboardSoundEditOptions): add missing reason #10863

merged 1 commit into from
Apr 28, 2025

Conversation

@sdanialraza
Copy link
Member

@sdanialraza sdanialraza commented Apr 28, 2025

Please describe the changes this PR makes and why it should be merged:
reason property was missing in GuildSoundboardSoundEditOptions

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza added this to the discord.js 14.19 milestone Apr 28, 2025
@sdanialraza sdanialraza requested a review from a team as a code owner April 28, 2025 15:59
@sdanialraza sdanialraza requested review from SpaceEEC, iCrawl, kyranet and vladfrangu and removed request for a team April 28, 2025 15:59
@vercel
Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Apr 28, 2025 3:59pm
discord-js-guide ⬜️ Ignored (Inspect) Apr 28, 2025 3:59pm

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 28, 2025
@Jiralite Jiralite merged commit e3c247e into v14 Apr 28, 2025
8 checks passed
@Jiralite Jiralite deleted the types/add-missing-reason branch April 28, 2025 16:21
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 28, 2025
@sdanialraza sdanialraza mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:discord.js semver:patch

Projects

discord.js
Archived in project

Milestone

discord.js 14.19

Development

Successfully merging this pull request may close these issues.

4 participants

@sdanialraza @Jiralite @Qjuh