Skip to content

Conversation

@sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Fixes emojiId and emojiName still being used in equals even when they don't exist anymore (changed in 7b3cfe4 (#10590))

Also removes the duplicate AuditLogEvent.SoundboardSoundUpdate in GuildAuditLogsEntry

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza added this to the discord.js 14.19 milestone Apr 27, 2025
@sdanialraza sdanialraza requested a review from a team as a code owner April 27, 2025 22:15
@sdanialraza sdanialraza requested review from SpaceEEC, iCrawl, kyranet and vladfrangu and removed request for a team April 27, 2025 22:15
@vercel
Copy link

vercel bot commented Apr 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Apr 27, 2025 10:15pm

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 27, 2025
@vladfrangu vladfrangu merged commit 5f3fc17 into v14 Apr 28, 2025
7 checks passed
@vladfrangu vladfrangu deleted the fix/wrong-emoji-comparison-equals branch April 28, 2025 05:46
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 28, 2025
@vladfrangu
Copy link
Member

Don't forget to forward-port if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants