fix(WebsocketManager): always emit shardDisconnect on unresumable close #10826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qjuh
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
didinele
approved these changes
Apr 7, 2025
iCrawl
approved these changes
Apr 11, 2025
vladfrangu
requested changes
Apr 17, 2025
github-project-automation
bot
moved this from Review Approved
to Review in Progress
in discord.js
vladfrangu
approved these changes
Apr 28, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Previously
Client#shardDisconnectwas only emitted if the cause was (through a chain of method calls)Client#destroy()being called. This was missing the cases where Discord caused the unresumable disconnect from the gateway, e.g. token reset.Status and versioning classification: