Skip to content

build!: Bump Node.js to 20 #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

build!: Bump Node.js to 20 #10616

merged 1 commit into from
Nov 27, 2024

Conversation

@Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 25, 2024 •
edited
Loading

All packages will now require Node.js 20 or above.

@Jiralite Jiralite requested a review from a team as a code owner November 25, 2024 19:21
@vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 4:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 4:00pm

@Jiralite Jiralite changed the title build: Bump Node.js to 20 build!: Bump Node.js to 20 Nov 25, 2024
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Nov 25, 2024
vladfrangu
vladfrangu approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump this across packages tbh, node 18 is EOL

@Renegade334
Copy link
Contributor

Renegade334 commented Nov 25, 2024

Should this also bump the @types/node build dependency?

@Jiralite Jiralite requested review from a team as code owners November 26, 2024 00:02
@Jiralite Jiralite requested review from ckohen and monbrey November 26, 2024 00:02
@codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.96%. Comparing base (3a1b3cc) to head (4be779b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10616      +/-   ##
==========================================
- Coverage   37.00%   36.96%   -0.05%     
==========================================
  Files         239      239              
  Lines       15296    15286      -10     
  Branches     1378     1378              
==========================================
- Hits         5660     5650      -10     
  Misses       9621     9621              
  Partials       15       15
Flag Coverage Δ
brokers 27.71% <ø> (-3.73%) ⬇️
builders 80.38% <ø> (ø)
collection 100.00% <ø> (ø)
formatters 97.47% <ø> (ø)
guide 0.54% <ø> (ø)
proxy 64.63% <ø> (ø)
rest 85.85% <ø> (ø)
util 41.42% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 69.84% <ø> (ø)
website 0.00% <ø> (ø)
ws 34.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite
Copy link
Member Author

Jiralite commented Nov 26, 2024

Should this also bump the @types/node build dependency?

I have bumped this dependency everywhere but for packages/rest and apps/guide. It seems doing this causes many errors that should be resolved separately.

@Jiralite Jiralite removed this from the discord.js 15.0.0 milestone Nov 26, 2024
@Jiralite
build: bump Node.js to 20
4be779b 
BREAKING CHANGE: Node.js 20 or above is required.
@Jiralite Jiralite merged commit e89c6b6 into main Nov 27, 2024
25 checks passed
@Jiralite Jiralite deleted the build/node-20 branch November 27, 2024 16:37
@Jiralite Jiralite mentioned this pull request Jul 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@didinele didinele didinele approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/scripts

@monbrey monbrey Awaiting requested review from monbrey monbrey is a code owner automatically assigned from discordjs/guide

@almostSouji almostSouji Awaiting requested review from almostSouji almostSouji is a code owner automatically assigned from discordjs/guide

Assignees

No one assigned

Labels

apps:website dependencies packages:api-extractor packages:api-extractor-model packages:brokers packages:builders packages:collection packages:core packages:create-discord-bot packages:discord.js packages:docgen packages:formatters packages:next packages:proxy packages:proxy-container packages:rest packages:ui packages:util packages:voice packages:ws semver:major

Projects

discord.js
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jiralite @Renegade334 @vladfrangu @iCrawl @didinele