feat: add subscriptions #10541
Merged
feat: add subscriptions #10541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Jiralite
reviewed
Oct 26, 2024
Jiralite
reviewed
Oct 26, 2024
vladfrangu
previously requested changes
Nov 4, 2024
Jiralite
previously requested changes
Nov 11, 2024
Member
There was a problem hiding this comment.
According to the documentation1 and the specification2, ends_at may now be null. This means this logic needs to be modified as Date.parse(null) will result in NaN:
discord.js/packages/discord.js/src/structures/Entitlement.js
Lines 84 to 93 in f2f7f1f
I say this, but the entitlement object itself on the documentation does not have it marked as nullable. It probably needs updating (discord/discord-api-docs#7268).
Footnotes
Jiralite
previously requested changes
Nov 15, 2024
Jiralite
approved these changes
Nov 22, 2024
Qjuh
requested changes
Nov 24, 2024
packages/discord.js/src/client/websocket/handlers/SUBSCRIPTION_DELETE.js
Outdated
Show resolved
Hide resolved
vladfrangu
approved these changes
Nov 25, 2024
Co-authored-by: Jiralite <[email protected]>
This reverts commit ba472bd.
didinele
approved these changes
Nov 28, 2024
Jiralite
added a commit
that referenced
this pull request
Dec 2, 2024
* feat: add subscriptions * types: fix fetch options types * fix: correct properties in patch method * chore: requested changes Co-authored-by: Jiralite <[email protected]> * fix: correct export syntax * chore(Entitlement): mark `ends_at` as nullable` * types(FetchSubscriptionOptions): add missing `cache` option * Revert "types(FetchSubscriptionOptions): add missing `cache` option" This reverts commit ba472bd. * chore(Entitlement): mark `startsTimestamp` as nullable * fix: requested changes * docs(SubscriptionManager): correct return type --------- Co-authored-by: Jiralite <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds subscriptions for mainlib
Status and versioning classification: