Skip to content

fix(Message): reacting returning undefined #10475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix(Message): reacting returning undefined #10475

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71dc4fc
fix(Message): reacting returning undefined
vladfrangu Sep 2, 2024
661c017
Merge branch 'main' into fix/message-react-returning-undefined
vladfrangu Sep 2, 2024
bbd437b
chore: apply suggestion
vladfrangu Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/discord.js/src/client/actions/Action.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,16 @@ class GenericAction {
getThreadMember(id, manager) {
return this.getPayload({ user_id: id }, manager, id, Partials.ThreadMember, false);
}

spreadInjectedData(data) {
const ret = {};

for (const symbol of Object.getOwnPropertySymbols(data)) {
ret[symbol] = data[symbol];
}

return ret;
}
}

module.exports = GenericAction;
8 changes: 7 additions & 1 deletion packages/discord.js/src/client/actions/MessageReactionAdd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ class MessageReactionAdd extends Action {
if (!user) return false;

// Verify channel
const channel = this.getChannel({ id: data.channel_id, guild_id: data.guild_id, user_id: data.user_id });
const channel = this.getChannel({
id: data.channel_id,
guild_id: data.guild_id,
user_id: data.user_id,
...this.spreadInjectedData(data),
});

if (!channel?.isTextBased()) return false;

// Verify message
Expand Down