-
-
Notifications
You must be signed in to change notification settings - Fork 4k
test: replace jest with vitest #10472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10472 +/- ##
==========================================
+ Coverage 35.36% 37.98% +2.62%
==========================================
Files 240 239 -1
Lines 14616 15484 +868
Branches 1220 1366 +146
==========================================
+ Hits 5169 5882 +713
- Misses 9400 9587 +187
+ Partials 47 15 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can you try to rebase your PR? Just start the rebase, and every time you get a merge issue on pnpm-lock.yaml, just run |
vladfrangu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a vitest config file for this too 🙏 Personally don't like relying on defaults
Please describe the changes this PR makes and why it should be merged:
This is to update voice to use vitest instead of jest. It was ignored previously because the mocks are annoying to convert.
The tests compile and pass as shown by the CI.
Status and versioning classification: