-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore: bump to @favware/cliff-jumper v4.1.0 and fix changelog generation #10459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
b7b3f35 to
2106e91
Compare
vladfrangu
approved these changes
Aug 24, 2024
iCrawl
approved these changes
Aug 24, 2024
almeidx
reviewed
Aug 24, 2024
almeidx
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This updates @favware/cliff-jumper to v4.1.0. Not many breaking changes to process. It is only the added
--skip-changelogto thepublish.dev.yml. Thecliff.tomlchange is a deduplication of the GitHub URL, but not strictly necessary.I also cleaned up the
CHANGELOG.mdfiles, removing any duplicate entries. I then also found the fix for git-cliff no longer adding new duplicate entries by comparing thecliff.toml's of this repo to the ones of the Sapphire Utilities monorepo and I noticed this repo settopo_ordertotruewhere Sapphire sets it tofalse. Matching Sapphire with this config I then rancliff-jumperthroughpnpm run release --skip-tagon every relevant package and the changelog generated is perfectly clean.Click here for a breakdown of packages (also posted on Discord)
@discordjs/[email protected]which causes the header to be# [14.16.0](https://github.com/discordjs/discord.js/compare/@discordjs/[email protected]) - (2024-08-24)from the template
This is definitely a git-cliff problem as I can repro it with
That said, the actual content of the changelog is correct. Only this one URL to a GitHub compare link is wrong.
choreandbuildcommits)choreandbuildcommits)choreandbuildcommits)Lastly, I also added typescript as a dev-dep to
api-extractor-modelbecause otherwisepnpm run buildfails because it cannot find the properly symlinked binary:Status and versioning classification: