Skip to content

fix(voice): mark stream as ended #10455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 31, 2024
Merged

fix(voice): mark stream as ended #10455

merged 7 commits into from
Dec 31, 2024

Conversation

@nyapat
Copy link
Contributor

@nyapat nyapat commented Aug 22, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

closes #8778

example:

  • subscribe to user.
  • user starts speaking (pipeline is: check if subscription exists, if stream exists, voice packets are decrypted, and pushed to stream)
  • user stops speaking (specifically when endbehavior aftersilence or afterinactivity determines its 'stopped', push null to mark end)
  • user starts speaking (subscription exists: yep, stream exists: yep, push to stream!)
  • error: pushing after stream EOF

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@nyapat
fix: mark stream as ended
674d4a3 
refactor: prefer destroying the stream
@nyapat nyapat requested a review from a team as a code owner August 22, 2024 12:16
@vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 8:43pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 8:43pm

vladfrangu
vladfrangu approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, can we get a test script for this too? 🙏

@codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.91%. Comparing base (a6685a3) to head (afab0b3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10455      +/-   ##
==========================================
+ Coverage   37.89%   37.91%   +0.02%     
==========================================
  Files         239      239              
  Lines       14874    14877       +3     
  Branches     1373     1376       +3     
==========================================
+ Hits         5636     5641       +5     
+ Misses       9227     9225       -2     
  Partials       11       11
Flag Coverage Δ
voice 69.99% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nyapat nyapat marked this pull request as draft August 23, 2024 10:25
@nyapat
Copy link
Contributor Author

nyapat commented Aug 23, 2024

drafted because putting tests was a good idea and i found undesirable behaviour (particularly annoying because the tests & actual context of the function don't align properly)

nyapat
nyapat commented Aug 25, 2024
View reviewed changes
@nyapat
refactor: callback for nextTick
d6a380e 
test: wait duration ms to check end

chore: eslint

test: end before timeout
@nyapat nyapat marked this pull request as ready for review August 25, 2024 09:53
@nyapat nyapat requested a review from vladfrangu August 31, 2024 03:26
vladfrangu
vladfrangu approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering voice is an "if may work" basis, and assuming you've tested this with actual discord behavior, LGTM

@Jiralite Jiralite added this to the voice 0.19.0 milestone Nov 18, 2024
almeidx
almeidx approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@kodiakhq kodiakhq bot merged commit bc3a0c8 into discordjs:main Dec 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:voice semver:patch

Projects

discord.js
Archived in project

Milestone

voice 0.19.0

Development

Successfully merging this pull request may close these issues.

Voice receiver stream error

5 participants

@nyapat @vladfrangu @kyranet @almeidx @Jiralite