fix(scripts): show name of inheriting class on search index #10424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
vladfrangu
approved these changes
Aug 2, 2024
ckohen
reviewed
Aug 2, 2024
ckohen
approved these changes
Aug 3, 2024
almeidx
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
With #10415 the name on search index includes the name of the class now, but for inherited properties it's the name of the defining class instead of the one the entry links to.
This PR fixes this and also changes the delimiter so the name for https://discord.js.org/docs/packages/discord.js/14.15.3/ClientUser:Class#bot would be
ClientUser#botinstead ofUser.botnow.Status and versioning classification: