Skip to content

Conversation

@almeidx
Copy link
Member

@almeidx almeidx commented Jul 6, 2024

Please describe the changes this PR makes and why it should be merged:
Add missing tests to achieve 100% coverage on the collection package

Status and versioning classification:

@almeidx almeidx requested a review from a team as a code owner July 6, 2024 20:22
@vercel
Copy link

vercel bot commented Jul 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jul 6, 2024 8:22pm
discord-js-guide ⬜️ Ignored (Inspect) Jul 6, 2024 8:22pm

@codecov
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.38%. Comparing base (4f59b74) to head (fdfac4d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10380      +/-   ##
==========================================
+ Coverage   50.35%   50.38%   +0.03%     
==========================================
  Files         228      228              
  Lines       20633    20633              
  Branches     1233     1236       +3     
==========================================
+ Hits        10389    10396       +7     
+ Misses      10199    10193       -6     
+ Partials       45       44       -1     
Flag Coverage Δ
collection 100.00% <ø> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@Jiralite Jiralite added this to the collection 2.2.0 milestone Jul 6, 2024
@kodiakhq kodiakhq bot merged commit d8e94d8 into main Jul 6, 2024
@kodiakhq kodiakhq bot deleted the test/complete-collection-coverage branch July 6, 2024 20:32
vladfrangu pushed a commit that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants