Skip to content

fix(MessageManager): poll methods don't need a channel id #10249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2024
Merged

fix(MessageManager): poll methods don't need a channel id #10249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c82095e
fix(MessageManager): end poll does not need channel id
didinele May 4, 2024
5d9c8c5
chore: rest of the work
didinele May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/discord.js/src/managers/MessageManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,11 @@ class MessageManager extends CachedManager {

/**
* Ends a poll.
* @param {Snowflake} channelId The id of the channel
* @param {Snowflake} messageId The id of the message
* @returns {Promise<Message>}
*/
async endPoll(channelId, messageId) {
const message = await this.client.rest.post(Routes.expirePoll(channelId, messageId));
async endPoll(messageId) {
const message = await this.client.rest.post(Routes.expirePoll(this.channel.id, messageId));
return this._add(message, false);
}

Expand Down