Skip to content

feat(MessageManager): poll methods #10239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2024
Merged

feat(MessageManager): poll methods #10239

merged 2 commits into from
May 2, 2024

Conversation

@almeidx
Copy link
Member

@almeidx almeidx commented May 1, 2024

Please describe the changes this PR makes and why it should be merged:
Add endPoll and fetchPollAnswerVoters methods to the MessageManager class to allow interacting with polls without them being cached.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@almeidx almeidx requested a review from a team as a code owner May 1, 2024 17:51
@vercel
Copy link

vercel bot commented May 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 6:16pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 6:16pm

@Jiralite Jiralite added this to the discord.js 14.15 milestone May 1, 2024
Jiralite
Jiralite reviewed May 1, 2024
View reviewed changes
@almeidx almeidx force-pushed the feat/poll-methods-on-messagemanager branch from 3eaec11 to 0523c7d Compare May 1, 2024 18:10
@almeidx almeidx force-pushed the feat/poll-methods-on-messagemanager branch from 0523c7d to f5ffc5c Compare May 1, 2024 18:12
Jiralite
Jiralite reviewed May 1, 2024
View reviewed changes
@almeidx @Jiralite
docs: wording
8cf1a6e 
Co-authored-by: Jiralite <[email protected]>
@kodiakhq kodiakhq bot merged commit 6cf094c into main May 2, 2024
@kodiakhq kodiakhq bot deleted the feat/poll-methods-on-messagemanager branch May 2, 2024 20:54
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@RobinSquared RobinSquared mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@Azzraya Azzraya mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@AlexEKinney AlexEKinney mentioned this pull request Aug 15, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 15, 2024
Open
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 18, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 18, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 19, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:discord.js semver:minor

Projects

discord.js
Archived in project

Milestone

discord.js 14.15

Development

Successfully merging this pull request may close these issues.

5 participants

@almeidx @vladfrangu @SpaceEEC @Jiralite