Skip to content

Conversation

@almeidx
Copy link
Member

@almeidx almeidx commented Dec 10, 2023

Please describe the changes this PR makes and why it should be merged:
Added an ESLint rule to enforce the use of readonly Array and Collection types in function/method parameters and interface properties

Status and versioning classification:

@almeidx almeidx requested a review from a team as a code owner December 10, 2023 17:56
@vercel
Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 0:27am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 0:27am

@Jiralite
Copy link
Member

Jiralite commented Dec 10, 2023

Is there one for const type parameters? Also, shouldn't we enforce these changes to all packages?

@Jiralite Jiralite added this to the discord.js 14.15 milestone Dec 10, 2023
@Jiralite Jiralite removed this from the discord.js 14.15 milestone Dec 10, 2023
@almeidx almeidx force-pushed the types/readonly-array branch from 79e11cb to ce71c13 Compare December 10, 2023 21:32
@almeidx almeidx force-pushed the types/readonly-array branch 2 times, most recently from 6b2c2bc to 6ab7685 Compare December 24, 2023 18:10
@almeidx almeidx requested a review from vladfrangu January 18, 2024 21:18
@Jiralite Jiralite added this to the discord.js 14.15 milestone Feb 3, 2024
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this won't break user code

@vladfrangu
Copy link
Member

Also this needs a rebase

@almeidx almeidx force-pushed the types/readonly-array branch from 6ab7685 to 7f4204b Compare February 23, 2024 00:27
@almeidx almeidx mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants