feat(GatewayActivity): add url & status display type fields#1326
Merged
vladfrangu merged 3 commits intodiscordjs:mainfrom Aug 10, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
foxfirecodes
changed the title
vladfrangu
reviewed
Aug 10, 2025
| * @see {@link https://discord.com/developers/docs/topics/gateway-events#activity-object-activity-assets} | ||
| */ | ||
| export type GatewayActivityAssets = Partial< | ||
| Record<'large_image' | 'large_text' | 'small_image' | 'small_text', string> |
Member
There was a problem hiding this comment.
I see this change isn't also in v9, is that intentional?
Contributor
Author
There was a problem hiding this comment.
woops! that was a mistake. i pushed a fix!
Member
|
Also you nailed it otherwise, v9 and v10 are getting the updates and you even got the deno part! 🥹💙 |
vladfrangu
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
a few weeks back i added some new functionality to activities around being able to make state/details/large/small image all have clickable links, as well as allowing users to customize which of name/state/details is used in their status message. this PR adds the corresponding new fields and types to the
GatewayActivitytypei wasn't sure whether or not to edit just the v10 types or the other versions. this is my first time contributing to this repo so any guidance is appreciated :3edit: i saw that changes to v8 and below were disallowed by CI, so i am assuming that i should then be making changes to v9 and v10. if this was wrong plz lmk
related pr that was looking to use these new types: pear-devs/pear-desktop#3692
If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
discord/discord-api-docs#7674