fix(CDNRoutes): inconsistency in route and wrong JSDoc #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
almeidx
changed the title
almeidx
requested changes
Jul 19, 2024
vaporoxx
suggested changes
Jul 19, 2024
Contributor
vaporoxx
left a comment
vaporoxx
left a comment
There was a problem hiding this comment.
The new route in the documentation doesn't match the actual route
Also while you're at it, the documentation for guildMemberAvatar is missing /avatars
vaporoxx
approved these changes
Jul 19, 2024
This was referenced Sep 6, 2024
This was referenced Sep 10, 2024
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged: It fixes an inconsistency in the guildIcon cdn route. This route does not start with
/like the rest of the routes. It also fixes it's JSDoc which is completely wrong.If applicable, please reference Discord API Docs PRs or commits that influenced this PR: None