This repository was archived by the owner on Jan 8, 2022. It is now read-only.
types(At): make index a required parameter #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Nov 6, 2021
|
Hi team. In playground v4.5.2, |
Contributor
Author
|
es2022 will be added in TS 4.6.0 as you can see in the linked PR. However this PR and repo have absolutely nothing to do with TS |
|
Ohh its discord repo! I like your project a lot. And thanks for the clarification! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR changes the typings for Collection#at and Collection#keyAt making the index parameter required. I labeled this as a types change because passing no index is still technically valid, but it was chosen to be considered invalid in TypeScript in the PR that introduced the es2022 lib, which came with Array.at() type definitions
Status and versioning classification: