update Text gradient colors to be mirrored on ios #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothy-huynh
force-pushed
the
thuynh/gradient-text-mirror-cherry-pick
branch
from
ef6c781 to
c2ffd04
Compare
bdbaraban
pushed a commit
that referenced
this pull request
May 22, 2025
Flewp
pushed a commit
that referenced
this pull request
Aug 25, 2025
Flewp
pushed a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When we added gradient colors to
Textin #54, we forgot to duplicate the first color to create a mirrored pattern. Without the duplicated first color, the color transitions abruptly from the last color back to the first color.Changelog:
TextTest Plan:
before
after