Skip to content

gradient text color fixes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timothy-huynh wants to merge 2 commits into from
Closed

gradient text color fixes #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
225805f
update Text gradient colors to be mirrored on ios
timothy-huynh Apr 30, 2025
3882d12
fix android gradient colors faded
timothy-huynh Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/Libraries/Text/RCTTextAttributes.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ - (UIColor *)effectiveForegroundColor
}

if([cgColors count] > 0) {
[cgColors addObject:cgColors[0]];
CAGradientLayer *gradient = [CAGradientLayer layer];
// this pattern width corresponds roughly to desktop's pattern width
int patternWidth = 100;
Expand Down
13 changes: 5 additions & 8 deletions ...ive/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,12 @@ private static void buildSpannedFromShadowNode(
}
int end = sb.length();
if (end >= start) {
if (textShadowNode.mIsColorSet || textShadowNode.mGradientColors != null) {
if (textShadowNode.mGradientColors != null && textShadowNode.mGradientColors.length >= 2) {
if (textShadowNode.mIsColorSet) {
ops.add(new SetSpanOperation(start, end, new ReactForegroundColorSpan(textShadowNode.mColor)));
}
if (textShadowNode.mGradientColors != null && textShadowNode.mGradientColors.length >= 2) {
int effectiveFontSize = textAttributes.getEffectiveFontSize();
ops.add(
new SetSpanOperation(start, end, new LinearGradientSpan(start * effectiveFontSize, textShadowNode.mGradientColors)));
} else {
ops.add(
new SetSpanOperation(start, end, new ReactForegroundColorSpan(textShadowNode.mColor)));
}
ops.add(new SetSpanOperation(start, end, new LinearGradientSpan(start * effectiveFontSize, textShadowNode.mGradientColors)));
}
if (textShadowNode.mIsBackgroundColorSet) {
ops.add(
Expand Down
3 changes: 3 additions & 0 deletions ...ctAndroid/src/main/java/com/facebook/react/views/text/internal/span/LinearGradientSpan.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ public class LinearGradientSpan(
) : CharacterStyle(), ReactSpan,
UpdateAppearance {
public override fun updateDrawState(tp: TextPaint) {
// without setting the paint color, the gradient appears "faded" if no foreground color span is also applied
// https://stackoverflow.com/a/52289927
tp.setColor(colors[0])
val textShader: Shader =
LinearGradient(
start,
Expand Down
Loading