Skip to content

Conversation

@timothy-huynh
Copy link

Summary:

This PR fixes gradient colors on text appearing "faded". The exact reason isn't known but I found this relevant stackoverflow answer and testing out the change shows that it works.

Changelog:

  • updated span operation logic to set a color span and a gradient color span if both are passed in (though visually the gradient color span takes precedence since it updates the shader itself)
  • updated LinearGradientSpan to call setColor on the first color too -> this is needed when a color isn't set such as when color="none" is passed from the React JS side

Test Plan:

  • tested guild member list
  • tested setting a random Text component with gradient colors

screenshots

Guild member list
before
image

after
image

Thread title
before
image

after
image

@timothy-huynh timothy-huynh merged commit 310eb46 into 0.76.6-discord May 1, 2025
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants