-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Document new rich presence url & status display type fields for Social SDK #7676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markmandel
merged 8 commits into
main
from
lew/add-url-and-status-display-rich-presence-fields-social-sdk
Sep 3, 2025
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9b7363f
add examples for social sdk
foxfirecodes 3c05187
add to gateway events
foxfirecodes dfc5227
add changelog entry
foxfirecodes 3b5e084
split out social sdk changes into separate pr
foxfirecodes 43bf3ad
add back social sdk changes
foxfirecodes 3ea989f
remove changelog
foxfirecodes 3e1410d
revert gateway events changes
foxfirecodes f881cf2
reorganize sections
foxfirecodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both of these sections would be better just below
## Setting Assetssince it flows naturally from there.I am wondering though if that section should be
## Setting Predefined Assetsand this should be something like## Setting Rich Presence Clickable Linksor something like that - that describes what you are doing.What do you think of that?
Down here we're in
## Rich Presence Without Authenticationwhich feels like the wrong section.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im good with moving them! i think that makes sense
i'm like 70% sure that you can set more than just predefined assets so i dont think renaming that section is necessary. as for renaming the field URLs section, i think it's redundant to say Rich Presence when we're on the rich presence page but i'm open to maybe doing "Setting Clickable Links" if that feels more intuitive to you than "Setting Field URLs"
so in the meantime ive moved the section, but left the headers the same. lmk your thoughts on if you still think the header could be reworded