Skip to content

Modify Channel::$createable attributes by type #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SQKo merged 10 commits into from
Jun 24, 2023
Merged

Modify Channel::$createable attributes by type #1112

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dca5ae6
Modify Channel::$createable attributes by type
SQKo Apr 30, 2023
f614446
use $attr['type'] instead of $this->type
SQKo Apr 30, 2023
50b4dac
use switch instead of several elseif
Exanlv Apr 30, 2023
aa8c11b
Forgot break
Exanlv Apr 30, 2023
db5a5ee
Modify Channel::$createable attributes by type
SQKo Apr 30, 2023
1fa65e8
use $attr['type'] instead of $this->type
SQKo Apr 30, 2023
1740ae4
use switch instead of several elseif
Exanlv Apr 30, 2023
ffa4740
Forgot break
Exanlv Apr 30, 2023
6049a16
Merge branch 'feat-channel-createable-attributes-type' of https://git…
SQKo Jun 24, 2023
33ef768
Channel::$createable by type
SQKo Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 70 additions & 29 deletions src/Discord/Parts/Channel/Channel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,40 +1371,81 @@ public function getBotPermissions(): ?RolePermission
*/
public function getCreatableAttributes(): array
{
$attr = [
'name' => $this->name,
// Required
$attr = ['name' => $this->name];

// Marked "Channel Type: All" in documentation
$attr += $this->makeOptionalAttributes([
'type' => $this->type,
'bitrate' => $this->bitrate,
'permission_overwrites' => $this->permission_overwrites,
'topic' => $this->topic,
'user_limit' => $this->user_limit,
'rate_limit_per_user' => $this->rate_limit_per_user,
'position' => $this->position,
'parent_id' => $this->parent_id,
'nsfw' => $this->nsfw,
'rtc_region' => $this->rtc_region,
'video_quality_mode' => $this->video_quality_mode,
'default_auto_archive_duration' => $this->default_auto_archive_duration,
];

if ($attr['type'] == self::TYPE_GUILD_TEXT) {
$attr['default_thread_rate_limit_per_user'] = $this->default_thread_rate_limit_per_user ?? null;
} elseif ($attr['type'] == self::TYPE_GUILD_FORUM) {
if (array_key_exists('default_reaction_emoji', $this->attributes)) {
$attr['default_reaction_emoji'] = $this->attributes['default_reaction_emoji'];
}

$attr['available_tags'] = $this->attributes['available_tags'] ?? null;

if (array_key_exists('default_sort_order', $this->attributes)) {
$attr['default_sort_order'] = $this->default_sort_order;
}
]);

if (array_key_exists('default_forum_layout', $this->attributes)) {
$attr['default_forum_layout'] = $this->default_forum_layout;
}
switch ($this->type) {
case self::TYPE_GUILD_TEXT:
$attr += $this->makeOptionalAttributes([
'topic' => $this->topic,
'rate_limit_per_user' => $this->rate_limit_per_user,
'parent_id' => $this->parent_id,
'nsfw' => $this->nsfw,
'default_auto_archive_duration' => $this->default_auto_archive_duration,
'default_thread_rate_limit_per_user' => $this->default_thread_rate_limit_per_user,
]);
break;

case self::TYPE_GUILD_VOICE:
$attr += $this->makeOptionalAttributes([
'bitrate' => $this->bitrate,
'user_limit' => $this->user_limit,
'rate_limit_per_user' => $this->rate_limit_per_user,
'parent_id' => $this->parent_id,
'nsfw' => $this->nsfw,
'rtc_region' => $this->rtc_region,
'video_quality_mode' => $this->video_quality_mode,
]);
break;

case self::TYPE_GUILD_ANNOUNCEMENT:
$attr += $this->makeOptionalAttributes([
'topic' => $this->topic,
'parent_id' => $this->parent_id,
'nsfw' => $this->nsfw,
'default_auto_archive_duration' => $this->default_auto_archive_duration,
]);
break;

case self::TYPE_GUILD_STAGE_VOICE:
$attr += $this->makeOptionalAttributes([
'bitrate' => $this->bitrate,
'user_limit' => $this->user_limit,
'rate_limit_per_user' => $this->rate_limit_per_user,
'parent_id' => $this->parent_id,
'nsfw' => $this->nsfw,
'rtc_region' => $this->rtc_region,
'video_quality_mode' => $this->video_quality_mode,
]);
break;

case self::TYPE_GUILD_FORUM:
$attr += $this->makeOptionalAttributes([
'topic' => $this->topic,
'rate_limit_per_user' => $this->rate_limit_per_user,
'parent_id' => $this->parent_id,
'nsfw' => $this->nsfw,
'default_auto_archive_duration' => $this->default_auto_archive_duration,
'default_reaction_emoji' => $this->attributes['default_reaction_emoji'] ?? null,
'available_tags' => $this->attributes['available_tags'] ?? null,
'default_sort_order' => $this->default_sort_order,
'default_forum_layout' => $this->default_forum_layout,
'default_thread_rate_limit_per_user' => $this->default_thread_rate_limit_per_user, // Canceled documentation #5606
]);
break;

$attr['default_thread_rate_limit_per_user'] = $this->default_thread_rate_limit_per_user ?? null;
case null:
// Type was not specified but we must not assume its default to GUILD_TEXT as that is determined by API
$this->discord->getLogger()->warning('Not specifying channel type, creating with all filled attributes');
$attr += $this->makeOptionalAttributes($this->getRawAttributes()); // Send the raw attributes
break;
}

return $attr;
Expand Down