Implemented resume_gateway_url. #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmir
approved these changes
Aug 21, 2022
MrCakeSlayer
approved these changes
Aug 21, 2022
quinchs
requested changes
Sep 2, 2022
Member
|
@Quahu Your move with the suggestions |
auto-merge was automatically disabled
September 3, 2022 19:01
Head branch was pushed to by a user without write access
quinchs
requested changes
Sep 9, 2022
quinchs
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the new
resume_gateway_url.I added two unrelated to my changes TODOs in
DiscordSocketApiClient.ConnectAsync()for logic that should probably be adjusted at some point, but I can remove them if you'd like me to.