Add tests for compiled route and use HttpUrl in Requester#3021
Open
MinnDevelopment wants to merge 9 commits intomasterfrom
Open
Add tests for compiled route and use HttpUrl in Requester#3021MinnDevelopment wants to merge 9 commits intomasterfrom
MinnDevelopment wants to merge 9 commits intomasterfrom
Conversation
MinnDevelopment
force-pushed
the
chore/route-tests
branch
from
857b093 to
136b74c
Compare
MinnDevelopment
force-pushed
the
chore/route-tests
branch
from
95d1e71 to
5d065dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
./gradlew formatChanges
Closes Issue: NaN
Description
This adds some security tests for
Route, to ensure we don't have any path navigation or query injection issues. I've also changedRequesterto useHttpUrlto ensure we are using valid URLs with an expected format.