Skip to content

Comments

Add errorprone for static code analysis#3011

Open
MinnDevelopment wants to merge 6 commits intomasterfrom
chore/errorprone
Open

Add errorprone for static code analysis#3011
MinnDevelopment wants to merge 6 commits intomasterfrom
chore/errorprone

Conversation

@MinnDevelopment
Copy link
Member

@MinnDevelopment MinnDevelopment commented Jan 21, 2026

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.
  • I have read the contributing guidelines.
  • I applied the code formatter to my changes with ./gradlew format

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: Linter

Closes Issue: NaN

Description

This will ensure we properly apply @Override on methods that should have it.

This comment was marked as resolved.

@MinnDevelopment MinnDevelopment changed the title Add errorprone to handle missing override annotations Add errorprone for static code analysis Jan 25, 2026
@arif-banai
Copy link
Contributor

arif-banai commented Feb 12, 2026

this PR would resolve a bug I've encountered when run with Turkish Locale.

When a user from Turkey ran my bot, I noticed this in the debug logs:
[DEBUG] [AudioWebSocket]: Using encryption mode aead_aes256_gcm_rtpsıze

This causes the audio connection to fail:

[DEBUG] [AudioWebSocket]: The Audio connection was closed!
[DEBUG] [AudioWebSocket]: Reason: Unknown encryption mode.

I was able to resolve this error by having the user run my bot with the following java args:
-Duser.language=en -Duser.country=US

The change made in AudioEncryption.java to use Locale.ROOT should fix this bug.

this.key = name().toLowerCase(Locale.ROOT);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants