Add errorprone for static code analysis#3011
Open
MinnDevelopment wants to merge 6 commits intomasterfrom
Open
Conversation
Contributor
|
this PR would resolve a bug I've encountered when run with Turkish Locale. When a user from Turkey ran my bot, I noticed this in the debug logs: This causes the audio connection to fail: I was able to resolve this error by having the user run my bot with the following java args: The change made in AudioEncryption.java to use Locale.ROOT should fix this bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
./gradlew formatChanges
Closes Issue: NaN
Description
This will ensure we properly apply
@Overrideon methods that should have it.