Add basic support for activities#2751
Conversation
40217d5 to
1201db8
Compare
DV8FromTheWorld
left a comment
There was a problem hiding this comment.
Nice work. Dropped a number of comments, but many are duplicates so when a decision is reached all the code is updated.
I think we should consider moving to "PrimaryEntrypointCommand" for a measure of consistency and code-self-explanation.
| @Nonnull | ||
| @CheckReturnValue | ||
| CommandListUpdateAction updateCommands(); | ||
| GlobalCommandListUpdateAction updateCommands(); |
There was a problem hiding this comment.
Does renaming this break ABI? I haven't read further here, but this strikes me a possible problem
There was a problem hiding this comment.
I believe yes, as the method signatures in the bytecode include the parameters and return type signatures
src/main/java/net/dv8tion/jda/api/events/interaction/ModalInteractionEvent.java
Outdated
Show resolved
Hide resolved
...net/dv8tion/jda/api/events/interaction/component/GenericComponentInteractionCreateEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/Interaction.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/callbacks/ILaunchActivityReplyCallback.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/build/attributes/INamedCommandData.java
Outdated
Show resolved
Hide resolved
.../java/net/dv8tion/jda/api/requests/restaction/interactions/LaunchActivityCallbackAction.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/build/EntryPointCommandData.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/command/CommandImpl.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/command/CommandInteractionImpl.java
Outdated
Show resolved
Hide resolved
1201db8 to
ddd678b
Compare
This is for commands updated globally
e3f8b06 to
20aa434
Compare
Slash command properties are also merged into |
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Adds basic support for activities:
PrimaryEntryPointCommandData)PrimaryEntryPointInteractionEvent)InteractionCallbackResponse#getActivityInstance()fromInteractionHook#getCallbackResponse()) created byILaunchActivityCallback#replyLaunchActivity()JDA#retrieveActivityInstanceById(String))